Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/indepented component styling #1029

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

JoeriRoijenga
Copy link
Contributor

@JoeriRoijenga JoeriRoijenga commented Dec 20, 2024

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rijkshuisstijl-community ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 2:17pm
rijkshuisstijl-community-templates ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 2:17pm
rvs-rivm-nl ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 2:17pm

@@ -9,6 +9,9 @@
--utrecht-blockquote-color: var(--utrecht-blockquote-content-color);
--utrecht-blockquote-font-size: var(--utrecht-blockquote-content-font-size);
--utrecht-document-font-family: var(--utrecht-blockquote-content-font-family);
--utrecht-blockquote-caption-font-size: var(--utrecht-blockquote-content-font-size);

line-height: 1.25;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kan dit uit een var komen?

@@ -3,8 +3,11 @@
* Copyright (c) 2021 Community for NL Design System
*/

.utrecht-breadcrumb-nav .utrecht-link:any-link {
line-height: var(--utrecht-breadcrumb-nav-line-height, inherit) !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moet dit important zijn?

@@ -8,3 +8,7 @@
.rhc-radio-group {
@include mixin.rhc-radio-group;
}

.utrecht-form-label {
line-height: 150%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waarom is dit 150%, kan dit uit een variabele komen of een rem zijn?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants